build: add rbac for default sa

[parth-gr]

rook csv doesnt contain the default
service account

recently we added default sa for most
of the ceph daemons but it didnt have the
rbacs, so added the rbacs to it
so rook csv can generate default sa

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[parth-gr]

Now we can see the service account.

[root@192 rook]# docker run --rm -it --platform=linux/amd64 --entrypoint=cat  quay.io/paarora/rook-operator:v471 /etc/ceph-csv-templates/rook-ceph.clusterserviceversion.yaml  | grep rook-ceph-default
          serviceAccountName: rook-ceph-default

[travisn]

Why is this pod get role added? I don't expect any new privileges for the default service account.

[parth-gr]

I can remove it

[parth-gr]

That was just for testing

[travisn]

If this is only needed for the csv, could we just add this during the csv generation script? I don't see why we need it in the rook repo

[parth-gr]

If this is only needed for the csv, could we just add this during the csv generation script? I don't see why we need it in the rook repo

at the end it will be in the rook image so doesn't matter, but to keep the flow same, lets discuss

[iamniting]

If this is only needed for the csv, could we just add this during the csv generation script? I don't see why we need it in the rook repo

It will be difficult to do such a hack during CSV generation. I would +1 for this PR. Maybe we can add a comment why do we need it.

[travisn]

Please sync up with @subhamkrai on related PR #13906

[subhamkrai]

Please sync up with @subhamkrai on related PR #13906

for now, we can add this in downstream repo only no need to add this in upstream and ocs-operator or build can use the downstream repo(which it does I guess)

[parth-gr]

Please sync up with @subhamkrai on related PR #13906

for now, we can add this in downstream repo only no need to add this in upstream and ocs-operator or build can use the downstream repo(which it does I guess)

Opened a PR red-hat-storage#589 hope it is easy to maintain, and from where red-hat-storage/rook:master this is genrated

[parth-gr]

closing as fixed in downstream