Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: increasing default metrics scraping interval from 5s to 10s #13923

Merged
merged 2 commits into from Mar 14, 2024

Conversation

rkachach
Copy link
Contributor

let's increase the monitoring interval to match the default interval used by Prometheus when deployed by Ceph: 10s

Closes: #13883

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

let's increase the monitoring interval to match the default interval
used by Prometheus when deployed by Ceph: 10s

Closes: rook#13883

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@rkachach rkachach requested review from travisn, avanthakkar and a team March 13, 2024 13:13
@travisn travisn changed the title monitoring: increasing metrics scraping interval from 5s to 10s monitoring: increasing default metrics scraping interval from 5s to 10s Mar 13, 2024
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some servicemonitor yaml files in the examples/monitoring folder. How about also updating their default?

@rkachach
Copy link
Contributor Author

There are also some servicemonitor yaml files in the examples/monitoring folder. How about also updating their default?

@travisn I updated all the references I found. Please, let me know if there're more files to be updated.

@rkachach rkachach requested a review from travisn March 14, 2024 14:59
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@travisn travisn merged commit 86dae9c into rook:master Mar 14, 2024
51 checks passed
mergify bot added a commit that referenced this pull request Mar 14, 2024
monitoring: increasing default metrics scraping interval from 5s to 10s (backport #13923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rook service monitor default scrape interval is 5s while Ceph Prometheus uses 10s
2 participants