helm: use toYaml for discovery nodeAffinity

[hhk7734]

Checklist:

• Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
• Reviewed the developer guide on Submitting a Pull Request
• Pending release notes updated with breaking and/or notable changes for the next minor release.
• Documentation has been updated, if necessary.
• Unit tests have been added, if necessary.
• Integration tests have been added, if necessary.

[travisn]

Thanks for the contribution. I see this will now have the same format that the CSI settings are already using, so it makes sense.

Could you just squash to a single commit? Or else the second commit needs a description message. A single commit is fine since it's the same description.

[hhk7734]

@travisn

I squashed it into a single commit :)

[parth-gr]

why quote @hhk7734 ?

[hhk7734]

an error occurs if there is no quote when using dict type yaml.

[hhk7734]

without quote

        - name: DISCOVER_AGENT_NODE_AFFINITY
          value: |
            {{- toYaml .Values.discover.nodeAffinity | nindent 12 }}

[parth-gr]

yes without quote make more sense to me, not sure how it is nindent if just specify the quote keyword, do you have any document that explains it

[hhk7734]

https://helm.sh/docs/chart_template_guide/functions_and_pipelines/

Using | quote in env[].value is very common, so I cannot get the reason to replace to nindent.

Even you can see using quote above this line.

[parth-gr]

thanks for the info!