Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update go version for govulncheck (backport #14175) #14177

Merged
merged 1 commit into from
May 8, 2024
Merged

ci: update go version for govulncheck (backport #14175) #14177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
steps:
- uses: actions/setup-go@v4
with:
go-version: "1.22.2"
go-version: "1.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.13 actually uses go v1.21 to build. We should probably cancel this backport and apply a special fix to specify go-version: "1.21" for release-1.13. Or we should additionally start building 1.13 using v1.22. Thoughts @travisn ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This govulncheck is already using 1.22, so this should just affect this single action. Otherwise, this will fail for all 1.13 PRs, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... true. I guess let's merge this and can follow up with 1.21 later if we want

check-latest: true
- name: govulncheck
uses: golang/govulncheck-action@v1
Loading