ci: update go version for govulncheck (backport #14175) #14177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Update the version of Go used for govulncheck to get the latest CVE fix present in Go v1.22.3. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com> (cherry picked from commit f21f3f5)
BlaineEXE
requested changes
May 8, 2024
| go-version: "1.22.2" | ||
| go-version: "1.22" |
There was a problem hiding this comment.
1.13 actually uses go v1.21 to build. We should probably cancel this backport and apply a special fix to specify go-version: "1.21" for release-1.13. Or we should additionally start building 1.13 using v1.22. Thoughts @travisn ?
There was a problem hiding this comment.
This govulncheck is already using 1.22, so this should just affect this single action. Otherwise, this will fail for all 1.13 PRs, right?
There was a problem hiding this comment.
Hmm... true. I guess let's merge this and can follow up with 1.21 later if we want
BlaineEXE
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version of Go used for govulncheck to get the latest CVE fix present in Go v1.22.3.
Related: #14027
Checklist:
This is an automatic backport of pull request #14175 done by [Mergify](https://mergify.com).