ceph: remove mon_max_pg_per_osd setting from cfg #2477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galexrt
approved these changes
Jan 10, 2019
BlaineEXE
force-pushed
the
fix-danger-setting-mon-max-pg-per-osd
branch
from
7f0b3cd
to
e44f42f
Compare
This setting is potentially dangerous, as it could hide misconfiguration errors from users. Signed-off-by: Blaine Gardner <blaine.gardner@suse.com>
BlaineEXE
force-pushed
the
fix-danger-setting-mon-max-pg-per-osd
branch
from
e44f42f
to
b5fc5a7
Compare
liewegas
approved these changes
Jan 10, 2019
|
What is the default setting? Is it much lower than 1000? |
|
Sage believed the default to be 300 and mentioned that the default is sometimes updated based on real-world user reports/issues. At least that was my understanding. |
|
I am guessing this is failing the integration tests because there is only one osd in the test env that starts with more than 300 pgs. There doesn't seem to be a log from the operator pod in the artifacts, which makes debugging hard. This seems like it may be related to the discussion started with this comment: https://github.com/rook/rook/pull/2470/files#r246889563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is potentially dangerous, as it could hide misconfiguration
errors from users.
Signed-off-by: Blaine Gardner blaine.gardner@suse.com
Checklist:
make codegen) has been run to update object specifications, if necessary.