Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: Removed the storage provisioners usage rules. #6019

Merged
merged 1 commit into from Aug 10, 2020

Conversation

anmolsachan
Copy link
Contributor

@anmolsachan anmolsachan commented Aug 10, 2020

In the interest of having the metrics available generically for all the storage provisioners and just not ceph provisioners, the superseding metrics will be added to Openshift directly. Thus, these metrics won't be required in rook.

PR on OCP for the same functionality: openshift/cluster-monitoring-operator#892

Also, fixes: #6011

Signed-off-by: Anmol Sachan anmol13694@gmail.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

[skip ci]

In the interest of having the metrics avaliable generically for all the storage provisioners and just not ceph, the superseding metrics will be added to Openshift directly. Thus these metrics wont be required in rook.

Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
@leseb leseb merged commit f652a6e into rook:master Aug 10, 2020
mergify bot added a commit that referenced this pull request Aug 10, 2020
ceph: Removed the storage provisioners usage rules. (bp #6019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus Rule failures with 'rook-ceph-prometheus-ceph-v15-rules.yaml;telemeter.rules' in 1.4.0
2 participants