Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: do not use realPath for osd on pvc #6120

Merged
merged 1 commit into from Aug 19, 2020
Merged

ceph: do not use realPath for osd on pvc #6120

merged 1 commit into from Aug 19, 2020

Conversation

leseb
Copy link
Member

@leseb leseb commented Aug 19, 2020

Description of your changes:

It is fine to use /mnt/set1-data-0-k47mc, it looks like I thought there
was an issue with udev but there is none...

Closes: #5996
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #5996

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Aug 19, 2020
@leseb
Copy link
Member Author

leseb commented Aug 19, 2020

Let's hold this one a bit, I need to validate a few things on the encryption scenario.

It is fine to use /mnt/set1-data-0-k47mc, it looks like I thought there
was an issue with udev but there is none...

Closes: rook#5996
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb changed the title ceph: only use realPath on encryption ceph: do not use realPath for osd on pvc Aug 19, 2020
@leseb leseb merged commit aa5362d into rook:master Aug 19, 2020
@leseb leseb deleted the fix-5996 branch August 19, 2020 15:33
mergify bot added a commit that referenced this pull request Aug 19, 2020
ceph: do not use realPath for osd on pvc (bp #6120)
@satoru-takeuchi
Copy link
Member

@leseb I confirmed the multi-cluster test passed with this PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c-v raw fails to list existing OSD (blocks CI)
3 participants