Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: run obc requests with debug #6170

Merged
merged 2 commits into from
Aug 27, 2020
Merged

ceph: run obc requests with debug #6170

merged 2 commits into from
Aug 27, 2020

Conversation

leseb
Copy link
Member

@leseb leseb commented Aug 26, 2020 •
edited
Loading

Description of your changes:

Use debug log to all the s3 calls so it's either to debug. Also, it's
not so verbose.

Example output of a bucket creation:

2020/08/26 16:10:19 DEBUG: Request s3/CreateBucket Details:
---[ REQUEST POST-SIGN ]-----------------------------
PUT /leseb-testing HTTP/1.1
Host: rook-ceph-rgw-ocs-storagecluster-cephobjectstore.openshift-storage.svc.cluster.local
User-Agent: aws-sdk-go/1.34.10 (go1.13.4; linux; amd64)
Content-Length: 0
Authorization: AWS4-HMAC-SHA256 Credential=KWT9T5AMC6X7DOIPI0KP/20200826/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=494fd28799922239355a30a701ba5aa899f06a2eedc881b7b15715b9baaee80c
X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
X-Amz-Date: 20200826T161019Z
Accept-Encoding: gzip


-----------------------------------------------------
2020/08/26 16:10:19 DEBUG: Response s3/CreateBucket Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 200 OK
Content-Length: 0
Connection: Keep-Alive
Date: Wed, 26 Aug 2020 16:10:19 GMT
X-Amz-Request-Id: tx000000000000000000113-005f46896b-ac9a-ocs-storagecluster-cephobjectstore


-----------------------------------------------------
2020/08/26 16:10:19

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: run obc requests with debug
bcd76bf 
Use debug log to all the s3 calls so it's either to debug. Also, it's
not so verbose.

Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Aug 26, 2020
@leseb leseb force-pushed the obc-log branch 2 times, most recently from 9e25d71 to 6b8276d Compare August 26, 2020 17:29
@leseb @travisn
ceph: use special dns suffix for object ep
3a92f98 
By addding ".svc.cluster.local" to the endpoint of the object store, the
OBC requests won't go through a proxy if any is configured.

Signed-off-by: Sébastien Han <seb@redhat.com>
@travisn travisn merged commit 85d72f7 into rook:master Aug 27, 2020
obnoxxx
obnoxxx reviewed Aug 27, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the second patch "use special dns suffix..." added, the PR title "run obc requests with debug" has become misleading. Can it be updated to reflect what the PR is doing? Or split this into two PRs?

@obnoxxx
Copy link
Contributor

obnoxxx commented Aug 27, 2020

ah, too late, merged :-) forget my comment

@leseb leseb deleted the obc-log branch August 27, 2020 07:37
This was referenced Aug 27, 2020
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 27, 2020
Merged
leseb added a commit that referenced this pull request Aug 27, 2020
@leseb
Merge pull request #6173 from leseb/bp-6170-release-1.3
6adc5da 
ceph: run obc requests with debug (bp #6170 on release-1.3)
leseb added a commit that referenced this pull request Aug 27, 2020
@leseb
Merge pull request #6172 from leseb/bp-6170-release-1.4
8b9bd73 
ceph: run obc requests with debug (bp #6170 on release-1.4)
@bartlaarhoven bartlaarhoven mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx left review comments

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leseb @obnoxxx @travisn