ceph: Cleanup mon canary pvc if the failover failed #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the mons are based on pvcs, the pvc_name label was not being set as expected. Now the label will always be set on both the canary and the daemon pods. The mon pvcs were also never being deleted during canary cleanup. This code is now removed since we must be very careful when the pvcs are removed. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
10 tasks
leseb
reviewed
Sep 10, 2020
| logger.Info("checking for orphaned mon resources") | ||
|
|
||
| if c.spec.Mon.VolumeClaimTemplate == nil { | ||
| logger.Info("skipping check for orphaned mon pvcs") |
There was a problem hiding this comment.
Suggested change
| logger.Info("skipping check for orphaned mon pvcs") | |
| logger.Info("skipping check for orphaned mon pvcs") |
Did you mean non-pvc?
There was a problem hiding this comment.
It's skipping the check for mon pvcs, it looks correct to me.
There was a problem hiding this comment.
But if the VolumeClaimTemplate is nil this means non-pvc right? 🤔
There was a problem hiding this comment.
That's right. There are no mon pvcs, so we skip checking for them. What about this?
logger.Info("skipping check for orphaned mon pvcs since using the host path")
| assert.NoError(t, err) | ||
| assert.Equal(t, 4, len(pvcs.Items)) | ||
|
|
||
| // pvc "b" should be removed and the others should remain |
travisn
force-pushed
the
cleanup-mon-canary-pvc
branch
from
902d7a8
to
50db4ac
Compare
If the mon failover fails, if the mon is on a pvc, the pvc could remain orphaned. This is likely to happen if there is not a node available for scheduling the mon. Therefore, the operator will ensure after a failover that any orphaned mon pvc is cleaned up. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
cleanup-mon-canary-pvc
branch
from
50db4ac
to
7a6620f
Compare
leseb
approved these changes
Sep 10, 2020
mergify bot
added a commit
that referenced
this pull request
Sep 10, 2020
ceph: Cleanup mon canary pvc if the failover failed (bp #6224)
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
If the mon failover fails and the mon is backed by a pvc, the pvc could remain orphaned. This is likely to happen if there is not a node available for scheduling the mon. Therefore, the operator will ensure after a failover that any orphaned mon pvc is cleaned up.
On a related change, the pvc_name label was not being set as expected on canary deployments. Now the label will always be set on both the canary and the daemon pods.
This replaces #6199.
Checklist:
make codegen) has been run to update object specifications, if necessary.