Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: Add unit tests for object store controller with multisite #6478

Merged
merged 1 commit into from
Oct 23, 2020
Merged

ceph: Add unit tests for object store controller with multisite #6478

merged 1 commit into from
Oct 23, 2020

Conversation

alimaredia
Copy link
Contributor

@alimaredia alimaredia commented Oct 22, 2020 •
edited
Loading

Add unit tests for when the "Zone" is configured
in an object store so that the object store joins
the CephObjectZone and the zone's corresponding
multisite configuration.

Signed-off-by: Ali Maredia amaredia@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #6387

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Oct 22, 2020
leseb
leseb requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: https://github.com/rook/rook/pull/6478/checks?check_run_id=1290632219

@alimaredia
ceph: add unit tests for object store controller with multisite
8964941 
Add unit tests for when the "Zone" is configured
in an object store so that the object store joins
the CephObjectZone and the zone's corresponding
multisite configuration.

Signed-off-by: Ali Maredia <amaredia@redhat.com>
@alimaredia alimaredia force-pushed the object-store-multisite-unit-tests branch from e6f7cb9 to 8964941 Compare October 22, 2020 15:36
This was referenced Oct 22, 2020
Closed
Closed
@leseb leseb merged commit 41f97c5 into rook:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object Store Multisite Unit Tests
3 participants
@alimaredia @leseb @travisn