Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: Label mon pods #6515

Merged
merged 2 commits into from Oct 30, 2020
Merged

ceph: Label mon pods #6515

merged 2 commits into from Oct 30, 2020

Conversation

yuseinishiyama
Copy link
Contributor

@yuseinishiyama yuseinishiyama commented Oct 30, 2020 •
edited

[test ceph]

Description of your changes:

#6084 enables users to add custom labels to rook-managed pods. It, however, does not propagate them to mon pods.
This PR fixes that and also improves comments and tests for ApplyToObjectMeta to mitigate my confusion while making this PR.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Oct 30, 2020
@yuseinishiyama yuseinishiyama changed the title ceph/mon: Label mon pods ceph: Label mon pods Oct 30, 2020
@yuseinishiyama
test: improve TestLabelsApply
2967bce 
To clarify the spec of ApplyToObjectMeta This also fixes the misleading
comments on the method.

Signed-off-by: Yusei Nishiyama <yusei.nishiyama@soundcloud.com>
@yuseinishiyama
ceph: propagte labels to mon pods
beaddb9 
To align it with how the other components are implemented in rook#6084

Signed-off-by: Yusei Nishiyama <yusei.nishiyama@soundcloud.com>
travisn
travisn approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the labels were on the deployment but not the pods, thanks!

@travisn travisn merged commit 024d1a8 into rook:master Oct 30, 2020
@mergify mergify bot mentioned this pull request Oct 30, 2020
Merged
mergify bot added a commit that referenced this pull request Oct 30, 2020
@mergify
Merge pull request #6517 from rook/mergify/bp/release-1.4/pr-6515
e38626e 
ceph: Label mon pods (bp #6515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuseinishiyama @travisn