Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: add external script to the container image #6648

Merged
merged 1 commit into from
Nov 17, 2020
Merged

ceph: add external script to the container image #6648

merged 1 commit into from
Nov 17, 2020

Conversation

leseb
Copy link
Member

@leseb leseb commented Nov 17, 2020

Description of your changes:

We now ship the Rook container image with our external cluster scripts.

Closes: #6644
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #6644

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: add external script to the container image
43484cb 
We now ship the Rook container image with our external cluster scripts.

Closes: rook#6644
Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Nov 17, 2020
@travisn travisn merged commit dbba7d7 into rook:master Nov 17, 2020
@mergify mergify bot mentioned this pull request Nov 17, 2020
Merged
@leseb leseb deleted the fix-6644 branch November 17, 2020 16:18
mergify bot added a commit that referenced this pull request Nov 17, 2020
@mergify
Merge pull request #6652 from rook/mergify/bp/release-1.5/pr-6648
ee50a5c 
ceph: add external script to the container image (bp #6648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include create-external-cluster-resources.sh script in toolbox
2 participants
@leseb @travisn