Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: fix cluster.yaml example #6763

Merged
merged 1 commit into from
Dec 4, 2020
Merged

ceph: fix cluster.yaml example #6763

merged 1 commit into from
Dec 4, 2020

Conversation

leseb
Copy link
Member

@leseb leseb commented Dec 4, 2020

Description of your changes:

Uncomment the cleanupPolicy: so that the file can be injected.

Closes: #6762
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #6762

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: fix cluster.yaml example
f2bfb09 
Uncomment the `cleanupPolicy:` so that the file can be injected.

Closes: rook#6762
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested review from travisn and galexrt December 4, 2020 09:20
@mergify mergify bot added the ceph main ceph tag label Dec 4, 2020
@leseb leseb merged commit 1cc4c22 into rook:master Dec 4, 2020
@leseb leseb deleted the fix-6762 branch December 4, 2020 09:39
@mergify mergify bot mentioned this pull request Dec 4, 2020
Merged
mergify bot added a commit that referenced this pull request Dec 4, 2020
@mergify
Merge pull request #6764 from rook/mergify/bp/release-1.5/pr-6763
17938cd 
ceph: fix cluster.yaml example (bp #6763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galexrt galexrt galexrt approved these changes

@travisn travisn Awaiting requested review from travisn

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error on cluster.yaml file
2 participants
@leseb @galexrt