ceph: fix #6214 New node is not provisioned when useAllNodes: true #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested changes
Dec 4, 2020
Signed-off-by: Stefan Haas <shaas@suse.com>
leseb
approved these changes
Dec 4, 2020
travisn
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new node got added rook checks if there is already an OSD running on that host via
ceph osd crush lsAs this is a new node
cephreturns with the errorENOENT. Rook handles this wrongly as a fatal error and aborts the addition of nodes.The fix checks in case of an error if
ENOENTis the reason and simply proceeds.Signed-off-by: Stefan Haas shaas@suse.com