Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: Suppress reconcile error after operator restart #6925

Merged

Conversation

travisn
Copy link
Member

@travisn travisn commented Jan 8, 2021

Description of your changes:
After the operator restarts, the controllers will not all be able to reconcile until the ceph config has been generated by the reconcile of the CephCluster controller. The message printed to the operator log is frequently seen as an error condition even though it is a normal condition where we requeue the reconcile until the config is available.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

After the operator restarts, the controllers will not all be able
to reconcile until the ceph config has been generated by the reconcile
of the CephCluster controller. The message printed to the operator log
is frequently seen as an error condition even though it is a normal
condition where we requeue the reconcile until the config is available.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn requested a review from leseb January 8, 2021 00:25
@mergify mergify bot added the ceph main ceph tag label Jan 8, 2021
@satoru-takeuchi satoru-takeuchi merged commit d643c59 into rook:master Jan 8, 2021
@travisn travisn deleted the reconcile-error-message-on-restart branch January 8, 2021 05:53
mergify bot added a commit that referenced this pull request Jan 8, 2021
ceph: Suppress reconcile error after operator restart (bp #6925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants