Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: fix malformations in common-external.yaml #6951

Merged
merged 1 commit into from
Jan 12, 2021
Merged

ceph: fix malformations in common-external.yaml #6951

merged 1 commit into from
Jan 12, 2021

Conversation

BlaineEXE
Copy link
Member

Fix accidental malformations in common-external.yaml manifest.
Find-replace operations seemingly replaced namespace with name in
some instances. Fix this.

This seems to have happened in #6809
Backport this to v1.5 since 6809's changes also were backported to v1.5.

Signed-off-by: Blaine Gardner blaine.gardner@redhat.com

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@BlaineEXE
ceph: fix malformations in common-external.yaml
1cf47f6 
Fix accidental malformations in common-external.yaml manifest.
Find-replace operations seemingly replaced `namespace` with `name` in
some instances. Fix this.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@BlaineEXE BlaineEXE merged commit 28a7d8f into rook:master Jan 12, 2021
@BlaineEXE BlaineEXE deleted the fix-cluster-external-example-malformations branch January 12, 2021 22:34
@mergify mergify bot mentioned this pull request Jan 12, 2021
Merged
mergify bot added a commit that referenced this pull request Jan 13, 2021
@mergify
Merge pull request #6953 from rook/mergify/bp/release-1.5/pr-6951
1c5e237 
ceph: fix malformations in common-external.yaml (bp #6951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@leseb leseb Awaiting requested review from leseb

@galexrt galexrt Awaiting requested review from galexrt

@satoru-takeuchi satoru-takeuchi Awaiting requested review from satoru-takeuchi

Assignees
No one assigned
Labels
bug ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BlaineEXE @travisn