Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: show error even in silent curl #7292

Merged
merged 1 commit into from Feb 23, 2021
Merged

ceph: show error even in silent curl #7292

merged 1 commit into from Feb 23, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Feb 23, 2021

The --silent option will remove the progress bar of the curl but also
silence any errors of stderr, so adding --show-error will display the
error even if --silent is used.

Signed-off-by: Sébastien Han seb@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: show error even in silent curl
069ff22 
The --silent option will remove the progress bar of the curl but also
silence any errors of stderr, so adding --show-error will display the
error even if --silent is used.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested a review from travisn February 23, 2021 16:16
@mergify mergify bot added the ceph main ceph tag label Feb 23, 2021
@leseb leseb merged commit dad4e4e into rook:master Feb 23, 2021
@leseb leseb deleted the bz-1931839 branch February 23, 2021 16:40
@mergify mergify bot mentioned this pull request Feb 23, 2021
Merged
mergify bot added a commit that referenced this pull request Feb 23, 2021
@mergify
Merge pull request #7293 from rook/mergify/bp/release-1.5/pr-7292
7ed10a3 
ceph: show error even in silent curl (bp #7292)
This was referenced Feb 23, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leseb @travisn