ceph: Persist expected mon endpoints immediately during mon failover #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp98
approved these changes
May 12, 2021
leseb
requested changes
May 12, 2021
There was a problem hiding this comment.
I think this can go away now since it's called by saveMonConfig():
rook/pkg/operator/ceph/cluster/mon/mon.go
Lines 505 to 508 in e06c36d
Agreed that is duplicated, I'll remove it |
travisn
force-pushed
the
mon-failover-window
branch
from
a72a773
to
35a2ae2
Compare
leseb
approved these changes
May 12, 2021
After mon failover is initiated, there was a time window where if the operator was restarted, the new mon is started and has joined quorum, but the operator does not believe the mon should be in quorum after the operator restart. The operator was mistakenly removing the extra mon prematurely, sometimes causing quorum to be lost if another mon was also down at the same time. If the mon does not come back online, steps to recover quroum would need to be followed from the disaster guide. Now the expected list of mons will be updated immediately during mon failover if the operator successfully created the new mon deployment, thus removing the window where restarting the operator can cause quorum loss. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
mon-failover-window
branch
from
35a2ae2
to
bb4191a
Compare
This was referenced May 12, 2021
mergify bot
added a commit
that referenced
this pull request
May 12, 2021
ceph: Persist expected mon endpoints immediately during mon failover (backport #7884)
mergify bot
added a commit
that referenced
this pull request
May 12, 2021
ceph: Persist expected mon endpoints immediately during mon failover (backport #7884)
airshipbot
pushed a commit
to airshipit/treasuremap
that referenced
this pull request
Jun 7, 2021
This PS is to update the rook operator image to v1.6.3. Release notes: https://github.com/rook/rook/releases/tag/v1.6.3 The storage team is specifically interested in: rook/rook#7951 rook/rook#7884 Change-Id: Iea9479ccb6664d499e90cbad46a43912f7936530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
After mon failover is initiated, there was a time window where if the operator was restarted, the new mon is started and has joined quorum, but the operator does not believe the mon should be in quorum after the operator restart. The operator was mistakenly removing the extra mon prematurely, sometimes causing quorum to be lost if another mon was also down at the same time. If the mon does not come back online, steps to recover quroum would need to be followed from the disaster guide. Now the expected list of mons will be updated immediately during mon failover if the operator successfully created the new mon deployment, thus removing the window where restarting the operator can cause quorum loss.
Most commonly this issue was hit during node drain where the operator might be restarted at a similar time that mon failover is triggered if node drains are taking longer than 10 min.
Which issue is resolved by this Pull Request:
Resolves #7797
Checklist:
make codegen) has been run to update object specifications, if necessary.