ceph: enable debug for adminops client if the rook loglevel <= debug #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested changes
Jun 28, 2021
thotz
force-pushed
the
enabledebugforadminOps
branch
from
e85eb08
to
5fb4721
Compare
leseb
approved these changes
Jun 29, 2021
|
Just to answer anyone who might have concerns, turning on DEBUG on the API does not leak connection credentials 😌 |
leseb
reviewed
Jun 30, 2021
leseb
requested changes
Jun 30, 2021
|
This pull request has merge conflicts that must be resolved before it can be merged. @thotz please rebase it. https://rook.io/docs/rook/master/development-flow.html#updating-your-fork |
The debug for adminOps client can be enabled by setting `Debug` flag. In this PR, it is enabled for OBC and cephobjectstore not healthchecker. Also add similar changes while calling `NewS3Agent` in the bucket provisioner code path. Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz
force-pushed
the
enabledebugforadminOps
branch
from
5fb4721
to
560f44b
Compare
Done |
leseb
approved these changes
Jul 1, 2021
mergify bot
added a commit
that referenced
this pull request
Jul 6, 2021
ceph: enable debug for adminops client if the rook loglevel <= debug (backport #8208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug for adminOps client can be enabled by setting
Debugflag.In this PR, it is enabled for OBC and cephobjectstore not healthchecker.
Also add similar changes while calling
NewS3Agentin the bucketprovisioner code path.
Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.