Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: add support for tls certs via k8s tls secrets for rgw #8243

Merged
merged 1 commit into from Jul 6, 2021
Merged

ceph: add support for tls certs via k8s tls secrets for rgw #8243

merged 1 commit into from Jul 6, 2021

Conversation

thotz
Copy link
Contributor

@thotz thotz commented Jul 2, 2021

Description of your changes:
With this PR the RGW can accept TLS certs as K8s TLS secrets

Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com

Which issue is resolved by this Pull Request:
Resolves #2079

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@thotz thotz requested a review from travisn July 2, 2021 13:08
@mergify mergify bot added the ceph main ceph tag label Jul 2, 2021
@travisn travisn requested a review from leseb July 2, 2021 19:39
@thotz thotz force-pushed the rgwk8stlssupport branch 3 times, most recently from 1717f6f to 45d64d6 Compare July 5, 2021 08:56
leseb
leseb requested changes Jul 5, 2021
View reviewed changes
pkg/operator/ceph/object/spec.go Outdated Show resolved Hide resolved
pkg/operator/ceph/object/spec.go Outdated Show resolved Hide resolved
pkg/operator/ceph/object/spec.go Show resolved Hide resolved
@thotz thotz requested review from leseb July 5, 2021 13:30
leseb
leseb requested changes Jul 6, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a release note

@thotz
ceph: add support for tls certs via k8s tls secrets for rgw
1665ad6 
With this PR the RGW can accept TLS certs as K8s TLS secrets

Fixes: 2079
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
@leseb leseb merged commit 93937fb into rook:master Jul 6, 2021
@oau-dev
Copy link

oau-dev commented Jul 6, 2021

great job ! many thx

@mergify mergify bot mentioned this pull request Jul 21, 2021
Merged
mergify bot added a commit that referenced this pull request Jul 22, 2021
@mergify
Merge pull request #8354 from rook/mergify/bp/release-1.6/pr-8243
acfa2d7 
ceph: add support for tls certs via k8s tls secrets for rgw (backport #8243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn Awaiting requested review from travisn

@leseb leseb Awaiting requested review from leseb

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow ObjectStore -> sslCertificateRef with standard kubernetes.io/tls certificates
4 participants
@thotz @oau-dev @leseb @galexrt