Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: Scaling down nfs deployment was failing #8250

Merged
merged 1 commit into from Jul 5, 2021
Merged

ceph: Scaling down nfs deployment was failing #8250

merged 1 commit into from Jul 5, 2021

Conversation

travisn
Copy link
Member

@travisn travisn commented Jul 2, 2021

Description of your changes:
When scaling down the nfs deployment gracefully, the wrong error code was checked,
resulting in a failed scaling down even though the condition was expected.
Now we check properly if the deployment was removed properly.

Which issue is resolved by this Pull Request:
Resolves #8231

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn
ceph: scaling down nfs deployment was failing
4b1cf51 
When scaling down the nfs deployment gracefully, the wrong error code was checked,
resulting in a failed scaling down even though the condition was expected.
Now we check properly if the deployment was removed properly.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn requested review from leseb and BlaineEXE July 2, 2021 18:06
@leseb leseb merged commit 23f3f17 into rook:master Jul 5, 2021
@mergify mergify bot mentioned this pull request Jul 5, 2021
Merged
mergify bot added a commit that referenced this pull request Jul 5, 2021
@mergify
Merge pull request #8259 from rook/mergify/bp/release-1.6/pr-8250
865340e 
ceph: Scaling down nfs deployment was failing (backport #8250)
@travisn travisn deleted the nfs-error-on-scaledown branch February 24, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@BlaineEXE BlaineEXE BlaineEXE approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create more than 2 working CephNFS resources
3 participants
@travisn @leseb @BlaineEXE