ceph: add missing ceph cluster spec #8310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
reviewed
Jul 13, 2021
The lib-bucket-provisioner was missing the cephCluster spec so the check in RunAdminCommandNoMultisite would fail. This is similar to ad54ed8 just a different place. Signed-off-by: Sébastien Han <seb@redhat.com>
BlaineEXE
approved these changes
Jul 13, 2021
travisn
reviewed
Jul 13, 2021
| if err != nil { | ||
| return errors.Wrapf(err, "failed to get ceph cluster in namespace %q", p.clusterInfo.Namespace) | ||
| } | ||
| if cephCluster == nil { |
There was a problem hiding this comment.
Why would the cluster be nil? If getCephCluster() returns Items[0], seems like it shouldn't be nil
mergify bot
added a commit
that referenced
this pull request
Jul 13, 2021
ceph: add missing ceph cluster spec (backport #8310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The lib-bucket-provisioner was missing the cephCluster spec so the check
in RunAdminCommandNoMultisite would fail.
This is similar to ad54ed8 just a
different place.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.