Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: modify the log info when ok to continue fails #8531

Closed
wants to merge 1 commit into from

Conversation

zeaone
Copy link

@zeaone zeaone commented Aug 12, 2021

Signed-off-by: Zeaone zeaone@ZeaonedeMacBook-Pro.local

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Signed-off-by: Zeaone <zeaone@ZeaonedeMacBook-Pro.local>
@mergify mergify bot added the ceph main ceph tag label Aug 12, 2021
@travisn
Copy link
Member

travisn commented Aug 12, 2021

Looks good, the bot is just complaining that the commit message can't end in ".", if you could just remove that. You can ignore the other CI failures, they look like known issues. Thanks!

@zeaone zeaone changed the title ceph: modify the log info when ok to continue fails. ceph: modify the log info when ok to continue fails Aug 13, 2021
@leseb
Copy link
Member

leseb commented Aug 24, 2021

Looks good, the bot is just complaining that the commit message can't end in ".", if you could just remove that. You can ignore the other CI failures, they look like known issues. Thanks!

+1 see https://rook.io/docs/rook/master/development-flow.html#commit-structure @zeaone thanks.

@leseb
Copy link
Member

leseb commented Sep 9, 2021

@subhamkrai please take over. Pick the commit and send a new PR you can add the author as a Co-authored-by in your commit. Thanks.

@leseb leseb closed this Sep 9, 2021
@subhamkrai
Copy link
Contributor

@subhamkrai please take over. Pick the commit and send a new PR you can add the author as a Co-authored-by in your commit. Thanks.

#8675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants