Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: modify the log info when ok to continue fails #8675

Merged
merged 1 commit into from Sep 9, 2021
Merged

ceph: modify the log info when ok to continue fails #8675

merged 1 commit into from Sep 9, 2021

Conversation

subhamkrai
Copy link
Contributor

correct typo in logging, it was showing ok-to-stop
instead of ok-to-continue when 'continueUpgradeAfterChecksEvenIfNotHealthy' is true

Co-Authored-by: Zeaone zeaone@ZeaonedeMacBook-Pro.local
Signed-off-by: subhamkrai srai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@subhamkrai
ceph: modify the log info when ok to continue fails
0657804 
correct typo in logging, it was showing `ok-to-stop`
instead of `ok-to-continue` when 'continueUpgradeAfterChecksEvenIfNotHealthy' is true

Co-Authored-by: Zeaone <zeaone@ZeaonedeMacBook-Pro.local>
Signed-off-by: subhamkrai <srai@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Sep 9, 2021
@subhamkrai subhamkrai mentioned this pull request Sep 9, 2021
Closed
10 tasks
@leseb leseb merged commit 031be4b into rook:master Sep 9, 2021
@mergify mergify bot mentioned this pull request Sep 9, 2021
Merged
@subhamkrai subhamkrai deleted the ok-continue branch September 9, 2021 15:34
mergify bot added a commit that referenced this pull request Sep 9, 2021
@mergify
Merge pull request #8679 from rook/mergify/bp/release-1.7/pr-8675
d1487d9 
ceph: modify the log info when ok to continue fails (backport #8675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@subhamkrai @leseb