Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfs: upgrade nfs-ganesha to 3.5 version #8534

Merged
merged 1 commit into from Aug 17, 2021

Conversation

kam1kaze
Copy link
Contributor

Signed-off-by: Oleksii Kravchenko kamikaze.ua@gmail.com

Description of your changes:
We start to use NFS rook operator a few weeks ago and were faced with the issue when NFS server was killed by OOM under the heavy load. Adding more memory didn't help. So I checked nfs-ganesha changelog for OOM fixes and found issue related to our problem nfs-ganesha/nfs-ganesha#116. It was merged in the recent version. Upgrade nfs-ganesha to 3.5 version completely resolves high memory consumption.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn
Copy link
Member

travisn commented Aug 16, 2021

The commitlint bot is complaining about the commit message. You can change it to:

nfs: bump nfs-ganesha to 3.5 version

Also please add a brief paragraph to the commit message explaining the change.

Copy link
Contributor

@thotz thotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since bumpup from 2.7 to 3.5 any nfs-ganesha config changes need to modified ?

Signed-off-by: Oleksii Kravchenko <kamikaze.ua@gmail.com>
@kam1kaze
Copy link
Contributor Author

@travisn just updated the commit message
@thotz https://github.com/nfs-ganesha/nfs-ganesha/blame/next/src/doc/man/ganesha-export-config.rst I didn't find any changes at least for the last 3 years.
BTW, we are using the updated version in prod for 1 week

@travisn travisn merged commit df36270 into rook:master Aug 17, 2021
mergify bot added a commit that referenced this pull request Aug 17, 2021
nfs: upgrade nfs-ganesha to 3.5 version (backport #8534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants