Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: make storage device config nullable #8552

Merged
merged 1 commit into from Aug 17, 2021
Merged

ceph: make storage device config nullable #8552

merged 1 commit into from Aug 17, 2021

Conversation

BlaineEXE
Copy link
Member

Signed-off-by: Blaine Gardner blaine.gardner@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #8550

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@BlaineEXE BlaineEXE added bug crd Changes related to a custom resource definition backport-release-1.6 labels Aug 17, 2021
@BlaineEXE BlaineEXE requested a review from travisn August 17, 2021 18:20
@mergify mergify bot added the ceph main ceph tag label Aug 17, 2021
@BlaineEXE
ceph: make storage device config nullable
36c53fe 
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@BlaineEXE BlaineEXE mentioned this pull request Aug 17, 2021
Closed
@travisn travisn merged commit 0f4c111 into rook:master Aug 17, 2021
This was referenced Aug 17, 2021
Merged
Merged
@BlaineEXE BlaineEXE deleted the make-device-config-nullable branch August 17, 2021 21:47
mergify bot added a commit that referenced this pull request Aug 17, 2021
@mergify
Merge pull request #8554 from rook/mergify/bp/release-1.6/pr-8552
9f84ce7 
ceph: make storage device config nullable (backport #8552)
travisn added a commit that referenced this pull request Aug 20, 2021
@travisn
Merge pull request #8555 from rook/mergify/bp/release-1.7/pr-8552
2445577 
ceph: make storage device config nullable (backport #8552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
bug ceph main ceph tag crd Changes related to a custom resource definition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to update cephcluster from 1.5.7 to 1.6.8 due to CRD change
2 participants
@BlaineEXE @travisn