Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: avoid multiple reconciles of ceph cluster #8638

Merged
merged 2 commits into from Sep 2, 2021
Merged

ceph: avoid multiple reconciles of ceph cluster #8638

merged 2 commits into from Sep 2, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 2, 2021

Description of your changes:

See commits.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: avoid double reconcile with default value
ab16674 
When setting a default values with kubebuilder flags it seems that the
kube operator intercepts the API call, mutate the CR and inject it.
This results in two events, one for creation and one for edition and we
end up with 2 reconciles. Let's avoid this.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
ceph: do not reconcile if the op is not ready
072c8f4 
When the op is initializing, the ceph config is not ready and thus we
should reconcile. This avoids a double reconcile.

Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Sep 2, 2021
@leseb leseb requested a review from travisn September 2, 2021 11:53
travisn
travisn approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice to have this fixed, I've seen this recently too!

@travisn travisn merged commit 790e01b into rook:master Sep 2, 2021
@leseb leseb deleted the avoid-multiple-reconcile branch September 2, 2021 14:29
@mergify mergify bot mentioned this pull request Sep 2, 2021
Merged
mergify bot added a commit that referenced this pull request Sep 2, 2021
@mergify
Merge pull request #8639 from rook/mergify/bp/release-1.7/pr-8638
a73f61b 
ceph: avoid multiple reconciles of ceph cluster (backport #8638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leseb @travisn