ceph: use node externalIP if no internalIP defined #8653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JrCs
force-pushed
the
externalip-failover
branch
from
53bf52d
to
2cf5b77
Compare
travisn
requested changes
Sep 7, 2021
There was a problem hiding this comment.
@JrCs See the unit test that needs to be updated:
=== RUN TestGetNodeInfoFromNode
node_test.go:226:
Error Trace: node_test.go:226
Error: Expected value not to be nil.
Test: TestGetNodeInfoFromNode
--- FAIL: TestGetNodeInfoFromNode (0.00s)
leseb
changed the title
leseb
requested changes
Sep 8, 2021
In some cases node internalIP is not defined. Then use externalIP if it exists. Signed-off-by: JrCs <90z7oey02@sneakemail.com>
JrCs
force-pushed
the
externalip-failover
branch
from
2cf5b77
to
c606f4c
Compare
|
@leseb tests added |
leseb
approved these changes
Sep 8, 2021
travisn
approved these changes
Sep 8, 2021
|
This pull request has merge conflicts that must be resolved before it can be merged. @JrCs please rebase it. https://rook.io/docs/rook/master/development-flow.html#updating-your-fork |
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2021
ceph: use node externalIP if no internalIP defined (backport #8653)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Use node externalIP if no internalIP defined
Which issue is resolved by this Pull Request:
Resolves #7866