Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: print the output on errors #8670

Merged
merged 1 commit into from Sep 9, 2021
Merged

ceph: print the output on errors #8670

merged 1 commit into from Sep 9, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 9, 2021

Description of your changes:

Sometimes the error does not tell much, so as exit status 1 and
printing the output along returning the error is useful.

For instance, I saw a job failing with no osd and the prepare job had
those lines:

exec: Running command: lsblk /dev/sdb1 --bytes --nodeps --pairs --paths --output SIZE,ROTA,RO,TYPE,PKNAME,NAME,KNAME
inventory: skipping device "sdb1". exit status 1

We need to understand more about the lsblk issue.

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ceph: print the output on errors
b7f5536 
Sometimes the error does not tell much, so as `exit status 1` and
printing the output along returning the error is useful.

For instance, I saw a job failing with no osd and the prepare job had
those lines:

```
exec: Running command: lsblk /dev/sdb1 --bytes --nodeps --pairs ....
inventory: skipping device "sdb1". exit status 1
```

We need to understand more about the lsblk issue.

Signed-off-by: Sébastien Han <seb@redhat.com>
@mergify mergify bot added the ceph main ceph tag label Sep 9, 2021
@leseb leseb requested a review from travisn September 9, 2021 12:43
@travisn travisn merged commit 3e14dbb into rook:master Sep 9, 2021
@mergify mergify bot mentioned this pull request Sep 9, 2021
Merged
@leseb leseb deleted the print-output branch September 9, 2021 13:44
mergify bot added a commit that referenced this pull request Sep 9, 2021
@mergify
Merge pull request #8672 from rook/mergify/bp/release-1.7/pr-8670
ab33e33 
ceph: print the output on errors (backport #8670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leseb @travisn