test: Create volume replication crds for yaml validation #9042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhamkrai
requested changes
Oct 27, 2021
Comment on lines
173
to
174
| kubectl create -f "${replication_url}/replication.storage.openshift.io_volumereplications.yaml" | ||
| kubectl create -f "${replication_url}/replication.storage.openshift.io_volumereplicationclasses.yaml" |
There was a problem hiding this comment.
indentation nit
Suggested change
| kubectl create -f "${replication_url}/replication.storage.openshift.io_volumereplications.yaml" | |
| kubectl create -f "${replication_url}/replication.storage.openshift.io_volumereplicationclasses.yaml" | |
| kubectl create -f "${replication_url}/replication.storage.openshift.io_volumereplications.yaml" | |
| kubectl create -f "${replication_url}/replication.storage.openshift.io_volumereplicationclasses.yaml" |
The yaml validation of the examples folder requires all the CRDs to be created in advance of the dry-run command. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
replication-crd-validation
branch
from
e17faf9
to
2c61ea2
Compare
subhamkrai
approved these changes
Oct 27, 2021
leseb
approved these changes
Oct 27, 2021
mergify bot
added a commit
that referenced
this pull request
Oct 27, 2021
test: Create volume replication crds for yaml validation (backport #9042)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The yaml validation of the examples folder requires all the CRDs to be created in advance of the dry-run command.
The issue this is fixing is that the canary integration test was failing with the following message in the yaml validation step:
Checklist:
make codegen) has been run to update object specifications, if necessary.