Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: Honor skipUpgradeChecks for OSDs #9290

Merged
merged 1 commit into from Dec 2, 2021
Merged

osd: Honor skipUpgradeChecks for OSDs #9290

merged 1 commit into from Dec 2, 2021

Conversation

travisn
Copy link
Member

@travisn travisn commented Dec 1, 2021

Description of your changes:
Skipping upgrade checks was not being honored for OSDs. Now the flag will be checked and allow the OSDs to be upgraded without checking for the ok-to-stop condition.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn
osd: honor skipUpgradeChecks for osds
32a884a 
Skipping upgrade checks was not being honored for OSDs.
Now the flag will be checked and allow the OSDs to be upgraded
without checking for the ok-to-stop condition.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@satoru-takeuchi satoru-takeuchi merged commit bdbb974 into rook:master Dec 2, 2021
@travisn travisn deleted the skip-osd-checks branch December 2, 2021 21:31
@mergify mergify bot mentioned this pull request Dec 2, 2021
Merged
mergify bot added a commit that referenced this pull request Dec 2, 2021
@mergify
Merge pull request #9302 from rook/mergify/bp/release-1.8/pr-9290
8b87833 
osd: Honor skipUpgradeChecks for OSDs (backport #9290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE BlaineEXE approved these changes

@satoru-takeuchi satoru-takeuchi satoru-takeuchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@travisn @BlaineEXE @satoru-takeuchi