Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: bump to ceph 16.2.7 #9343

Merged
merged 1 commit into from
Dec 8, 2021
Merged

core: bump to ceph 16.2.7 #9343

merged 1 commit into from
Dec 8, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Dec 8, 2021

Description of your changes:

ceph 16.2.7 is out so let's use it in our manifests.

Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Documentation/ceph-object-store-crd.md Outdated Show resolved Hide resolved
Documentation/ceph-upgrade.md Outdated Show resolved Hide resolved
@@ -45,7 +45,7 @@ const (
// test with the latest octopus build
octopusTestImage = "quay.io/ceph/ceph:v15"
// test with the latest pacific build
pacificTestImage = "quay.io/ceph/ceph:v16.2.6"
pacificTestImage = "quay.io/ceph/ceph:v16.2.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just change this to the latest like with the octopus test tag?

Suggested change
pacificTestImage = "quay.io/ceph/ceph:v16.2.7"
pacificTestImage = "quay.io/ceph/ceph:v16"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's use 16.2 instead so we don't test on pre-release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v16 is expected to point to the latest v16 patch release, so currently is the same as v16.2.7. When would it be a prerelease?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By pre-release I meant tags like 16.0 and 16.1, which are like alpha and beta tag IIRC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, and since the v16 tag always points to the latest v16.2.x, the v16 and v16.2 tags are equivalent now.

ceph 16.2.7 is out so let's use it in our manifests.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb merged commit 2bba4f1 into rook:master Dec 8, 2021
@leseb leseb deleted the bump-to-16.2.7 branch December 8, 2021 17:03
mergify bot added a commit that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants