Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Update CI to the latest helm and fix the linter #9642

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

travisn
Copy link
Member

@travisn travisn commented Jan 24, 2022

Description of your changes:

  • The CI was building with helm 3.6.2, now updating to the latest v3.8.0
  • Recent versions of helm are failing the linter on the end tag if the tag is {{- end -}}. Instead, the correct end tag is {{- end }}.

Which issue is resolved by this Pull Request:
Resolves #9639

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Recent versions of helm are failing the linter on the end tag
if the tag is "{{- end -}}". Instead, the correct end tag
is "{{- end }}".

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
The CI was building with helm 3.6.2, now updating to
the latest v3.8.0

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn merged commit 8fd1f1a into rook:master Jan 24, 2022
@travisn travisn deleted the helm-lint branch January 24, 2022 23:47
mergify bot added a commit that referenced this pull request Jan 25, 2022
helm: Update CI to the latest helm and fix the linter (backport #9642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: rook-ceph: helm lint is unable to parse rolebinding.yaml
2 participants