Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: Check for application already being set #9649

Merged
merged 1 commit into from
Jan 25, 2022
Merged

pool: Check for application already being set #9649

merged 1 commit into from
Jan 25, 2022

Conversation

travisn
Copy link
Member

@travisn travisn commented Jan 25, 2022

Description of your changes:
If the pool application is already set, skip setting it again to avoid a warning message being logged that it is already set.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn
pool: check for application already being set
e0cfb4f 
If the pool application is already set, skip setting it again
to avoid a warning message being logged that it is already
set.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
BlaineEXE
BlaineEXE approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we know what Ceph does if we try to change the pool's application? I.e., does the --yes-i-really-mean-it flag force the operation?

@travisn
Copy link
Member Author

travisn commented Jan 25, 2022

LGTM. Do we know what Ceph does if we try to change the pool's application? I.e., does the --yes-i-really-mean-it flag force the operation?

Yes I believe we would need that flag to change the application. But we will never change the application and it's not configurable by the user (except in the toolbox) so I don't think we need to worry about it.

@travisn travisn merged commit 4ef7981 into rook:master Jan 25, 2022
@travisn travisn deleted the check-application-pool branch January 25, 2022 22:39
@mergify mergify bot mentioned this pull request Jan 25, 2022
Merged
mergify bot added a commit that referenced this pull request Jan 25, 2022
@mergify
Merge pull request #9650 from rook/mergify/bp/release-1.8/pr-9649
9568850 
pool: Check for application already being set (backport #9649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE BlaineEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisn @BlaineEXE