Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for instance creation #14

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

envis10n
Copy link

Applied formatting
Added unit test for instance creation and usage

This fixes #2 which is caused by the Object.assign using the base axiod object's functions, which all refer to axiod.request

Doing this, it will always be calling with the regular defaults, since there is no actual inheritance involved with the axiod.create method. My fix here is quick and dirty, but I think binding this as the new instance and using this in the function calls could fix this much more cleanly.

Applied formatting
Added unit test for instance creation and usage.
@netroy
Copy link

netroy commented Jul 13, 2021

@roonie007 can we please have this merged ?

@envis10n
Copy link
Author

@roonie007 can we please have this merged ?

If you desperately need to use it before being merged, I have it forked over on my profile and you can use the raw link in your project. I may end up making some more adjustments and then publishing my own version to deno.land/x/ since this seems to be abandoned or no longer a focus of the creator.

@roonie007 roonie007 merged commit 33e6ffa into roonie007:master Jul 13, 2021
@roonie007
Copy link
Owner

@netroy @envis10n Done :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Didnt find my baseURL
3 participants