Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving the message list out of a overflow: scroll div #13

Closed
davidben opened this issue Jul 24, 2013 · 2 comments
Closed

Consider moving the message list out of a overflow: scroll div #13

davidben opened this issue Jul 24, 2013 · 2 comments

Comments

@davidben
Copy link
Contributor

It makes me sad as far as layering goes, but would solve the current focusing problem. It also doesn't seem like Chrome knows to composite them yet? But they should fix that, and they seem to be working on it...

@davidben
Copy link
Contributor Author

Yeah, I think I want to do this. The scrollbar should be at the edge anyway.

@davidben
Copy link
Contributor Author

One complication is that the bounds of the container are now less obvious. This should hopefully be just a matter of replacing all the this.container_.getBoundingClientRect calls with a callback or something. Also loadingAbove_ when loaded will be more complex.

Seriously, can we just replace those two with Angular chunks? I'd like to replace the messages themselves with Angular chunks, certainly. The main complexity is that I need control over when they actually update to fix up the scroll. Maybe some sort of delayed-update directive?

davidben added a commit that referenced this issue Aug 5, 2013
This was referenced Aug 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant