Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACLiC flags parsing for compiler command line options broken in certain cases #10866

Closed
cholmcc opened this issue Jun 30, 2022 · 0 comments · Fixed by #14753
Closed

ACLiC flags parsing for compiler command line options broken in certain cases #10866

cholmcc opened this issue Jun 30, 2022 · 0 comments · Fixed by #14753
Assignees
@pcanal @dpiparo
Labels
bug fixathon This issue can be tackled at a ROOT fixathon
Projects
Fixed in 6.32.00

Comments

@cholmcc
Copy link

cholmcc commented Jun 30, 2022

Hi all.

Please see the attach
Foo.zip
for a Minimal-(non)Working-Example (MWE), as well as a somewhat deeper explanation.

The problem is that ROOT may split the ACLiC flags (e.g., -I...) wrongly in certain cases. E.g.,

-I/some/path/with-xin-it

may become two distinct compiler arguments

-I/some/path/wit
-xin-it

which causes ACLiC to fail.

ROOT 6.26/00 on Debian GNU/Linux "sid"

Yours,

Christian
@cholmcc cholmcc added the bug label Jun 30, 2022
@dpiparo dpiparo assigned dpiparo and unassigned Axel-Naumann Feb 4, 2024
@vepadulano vepadulano added the fixathon This issue can be tackled at a ROOT fixathon label Feb 5, 2024
bellenot added a commit to bellenot/root that referenced this issue Feb 16, 2024
@bellenot
[core] Improve Include PATH handling & add test
391d8aa 
Should fix root-project#10866
@bellenot bellenot mentioned this issue Feb 16, 2024
Merged
bellenot added a commit that referenced this issue Feb 19, 2024
@bellenot
[core] Improve Include PATH handling & add test (#14753)
85ad181 
* [core] Improve Include PATH handling & add test

Should fix #10866

* [core] clang-format
@bellenot bellenot added this to Issues in Fixed in 6.32.00 via automation Feb 19, 2024
lobis pushed a commit to lobis/root that referenced this issue Apr 10, 2024
@bellenot @lobis
[core] Improve Include PATH handling & add test (root-project#14753)
d8e78e7 
* [core] Improve Include PATH handling & add test

Should fix root-project#10866

* [core] clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcanal pcanal

@dpiparo dpiparo

Labels
bug fixathon This issue can be tackled at a ROOT fixathon
Projects
Fixathon
Status: Done
Fixed in 6.32.00
Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Improve Include PATH handling & add test bellenot/root
5 participants
@Axel-Naumann @pcanal @cholmcc @dpiparo @vepadulano