Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve Include PATH handling & add test #14753

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[core] Improve Include PATH handling & add test #14753

merged 2 commits into from
Feb 19, 2024

Conversation

bellenot
Copy link
Member

Should fix #10866

@bellenot bellenot self-assigned this Feb 16, 2024
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal
pcanal approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2024 •
edited
Loading

Test Results

    12 files      12 suites   2d 1h 12m 35s ⏱️
 2 562 tests  2 559 ✅ 0 💤 3 ❌
28 822 runs  28 817 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit f1e6925.

♻️ This comment has been updated with latest results.

@bellenot bellenot merged commit 85ad181 into root-project:master Feb 19, 2024
10 of 17 checks passed
@bellenot bellenot deleted the fix-10866 branch February 19, 2024 12:00
lobis pushed a commit to lobis/root that referenced this pull request Apr 10, 2024
@bellenot @lobis
[core] Improve Include PATH handling & add test (root-project#14753)
d8e78e7 
* [core] Improve Include PATH handling & add test

Should fix root-project#10866

* [core] clang-format
silverweed pushed a commit to silverweed/root that referenced this pull request Aug 19, 2024
@bellenot
[core] Improve Include PATH handling & add test (root-project#14753)
f81d237 
* [core] Improve Include PATH handling & add test

Should fix root-project#10866

* [core] clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@bellenot bellenot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACLiC flags parsing for compiler command line options broken in certain cases
3 participants
@bellenot @phsft-bot @pcanal