Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THnSparse::Scale() unsparsifies #13962

Closed
1 task
Axel-Naumann opened this issue Oct 27, 2023 · 1 comment · Fixed by #15066
Closed
1 task

THnSparse::Scale() unsparsifies #13962

Axel-Naumann opened this issue Oct 27, 2023 · 1 comment · Fixed by #15066
Assignees
@dpiparo
Labels
bug

Comments

@Axel-Naumann
Copy link
Member

Check duplicate issues.

  • Checked for duplicates

Description

Scale() scales all bins, even "non-existing" (i.e. sparse-skipped) ones. See https://root-forum.cern.ch/t/hadd-error-thnsparse/56444

Reproducer

h->Scale() will do

ROOT version

master

Installation method

From source

Operating system

Linux

Additional context

No response
@Axel-Naumann Axel-Naumann self-assigned this Oct 27, 2023
@dpiparo dpiparo assigned dpiparo and unassigned Axel-Naumann Mar 24, 2024
ferdymercury added a commit to ferdymercury/root that referenced this issue Mar 27, 2024
@ferdymercury
[hist] THnSparse::Scale iterate only over non-filled bins
780d066 
Fixes root-project#13962
@ferdymercury ferdymercury mentioned this issue Mar 27, 2024
Merged
2 tasks
@ferdymercury
Copy link
Collaborator

PR here: #15066

guitargeek pushed a commit that referenced this issue Apr 8, 2024
@ferdymercury
[hist] Use virtual THnBase::CreateIter to generalize
926043c 
Fixes #13962
guitargeek pushed a commit to guitargeek/root that referenced this issue Apr 8, 2024
@ferdymercury @guitargeek
[hist] Use virtual THnBase::CreateIter to generalize
9bb4aad 
Fixes root-project#13962
guitargeek pushed a commit that referenced this issue Apr 8, 2024
@ferdymercury @guitargeek
[hist] Use virtual THnBase::CreateIter to generalize
72c816a 
Fixes #13962
aandvalenzuela pushed a commit to cms-sw/root that referenced this issue Apr 8, 2024
@ferdymercury @aandvalenzuela
[hist] Use virtual THnBase::CreateIter to generalize
8f5c2cf 
Fixes root-project#13962
kristupaspranc pushed a commit to kristupaspranc/root that referenced this issue Apr 10, 2024
@ferdymercury @kristupaspranc
[hist] Use virtual THnBase::CreateIter to generalize
b96e252 
Fixes root-project#13962
lobis pushed a commit to lobis/root that referenced this issue Apr 10, 2024
@ferdymercury @lobis
[hist] Use virtual THnBase::CreateIter to generalize
11e4e50 
Fixes root-project#13962
kristupaspranc pushed a commit to kristupaspranc/root that referenced this issue May 21, 2024
@ferdymercury
[hist] Use virtual THnBase::CreateIter to generalize
6d13a47 
Fixes root-project#13962
silverweed pushed a commit to silverweed/root that referenced this issue Aug 19, 2024
@ferdymercury
[hist] Use virtual THnBase::CreateIter to generalize
6b15986 
Fixes root-project#13962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpiparo dpiparo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[hist] THnSparse::Scale iterate only over non-filled bins ferdymercury/root
3 participants
@Axel-Naumann @dpiparo @ferdymercury