-
Notifications
You must be signed in to change notification settings - Fork 1.3k
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DF] Jitted Min method breaks with RVec columns #6435
Comments
eguiraud
added a commit
to eguiraud/root
that referenced
this issue
Sep 24, 2020
eguiraud
added a commit
to eguiraud/root
that referenced
this issue
Sep 24, 2020
When the Min or Max actions are jitted, their result type is always double, independently of the column type. If the column type happens to be of a different type, std::min won't compile because template parameter type deduction is ambiguous. We now always explicitly cast the arguments of std::min to the desired result type to avoid the ambiguity. This fixes root-project#6435.
eguiraud
added a commit
to eguiraud/root
that referenced
this issue
Sep 24, 2020
When the Min or Max actions are jitted, their result type is always double, independently of the column type. If the column type happens to be of a different type, std::min won't compile because template parameter type deduction is ambiguous. We now always explicitly cast the arguments of std::min to the desired result type to avoid the ambiguity. This fixes root-project#6435.
eguiraud
added a commit
that referenced
this issue
Sep 25, 2020
When the Min or Max actions are jitted, their result type is always double, independently of the column type. If the column type happens to be of a different type, std::min won't compile because template parameter type deduction is ambiguous. We now always explicitly cast the arguments of std::min to the desired result type to avoid the ambiguity. This fixes #6435.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Jitted Min calls break with RVec columns, although they work fine with scalars and if the RVec type is passed explicitly as a template parameter. Max is not affected.
To Reproduce
Setup
ROOT 6.22.02
Additional context
First reported on the forum.
The text was updated successfully, but these errors were encountered: