-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external nlohmann/json.hpp is not forwarded as dependency or should be linked PRIVATE? #6784
Comments
Yes, I can confirm a problem. |
@oshadura, according to this cmake docu, one have to add something like I did not found any example of usage of this macro in ROOT.
fail while Should I try with |
I agree that it is an exceptional case, I just not very happy that we will add only |
May be it can be good starting point! For many components (like If we would use standard |
@linev totally agree with you, we will definitely need to review other builtins/dependencies... |
In such case one requires external nlohmann_json::nlohmann_json to get proper include paths
I hope, now it should work. PR #6788 has to fix a problem |
Thanks for quickly taking care of this! |
Describe the bug
If the external nhlohman json is used ROOT an error occurs if ROOTEve is used
(original discovery via lcg nightlies in DD4hep package build on top of root master
Expected behavior
ROOT targets resolve all their dependencies so that other CMake projects can use them without error or change to their cmake
Find_dependency
added to e.g., ROOTConfig.cmakeor
this needs to be PRIVATE ?
https://github.com/linev/root/blob/88bdfd736f0b859b40973c457b75df9c73b0bbaf/graf3d/eve7/CMakeLists.txt#L139
To Reproduce
have a project with a library linking against ROOTEve
Assuming
cmake
is in the PATH (compiler and OS shouldn't matter)gives
Setup
cmake ... -Dbuiltin_nlohmannjson=OFF ....
The text was updated successfully, but these errors were encountered: