Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Clarify usage of RooParametricStepFunction #7748

Closed
ynikitenko opened this issue Mar 30, 2021 · 0 comments · Fixed by #10798
Closed

[RF] Clarify usage of RooParametricStepFunction #7748

ynikitenko opened this issue Mar 30, 2021 · 0 comments · Fixed by #10798

Comments

@ynikitenko
Copy link

  • [x ] Checked for duplicates

Describe the bug

In the documentation of RooParametricStepFunction the last line of the example goes like

RooParametricStepFunction  aPdf = ("aPdf","PSF",*x, 
    *list,limits,nbins);

where x is undefined in that code sample.

Expected behavior

Please write what x in that example is (that is some RooAbsReal).
Could you please also add the usage of this function? As I understand, it gets its values from a histogram (or does it fit a histogram), so it would be nice to introduce that histogram to the example.
I found no references to this class in tutorials.

P.S. I couldn't run this code in ROOT v.6.22/06 because of the error

error: reference to 'list' is ambiguous
list,limits,nbins);
^
ROOT_prompt_3:1:13: note: candidate found by name lookup is '__cling_N54::list'
RooArgList
list = new RooArgList("list");
^
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../include/c++/10.2.0/bits/stl_list.h:556:11: note: candidate found by name lookup is 'std::__cxx11::list'
class list : protected _List_base<_Tp, _Alloc>

@ynikitenko ynikitenko added the bug label Mar 30, 2021
guitargeek added a commit to guitargeek/root that referenced this issue Jun 22, 2022
The `RooParametricStepFunction` is not used much, but still there is an
issue requesting to explain its usage better that needs to be closed.

I don't think it's worth it to have a tutorial for it, but nothing
speaks about having a little complete usage example script in the
reference guide instead of the code stub that is there right now.

This change to the documentation goes together with some gentle code
modernization in this commit.

Closes root-project#7748.
@guitargeek guitargeek changed the title Clarify usage of RooParametricStepFunction [RF] Clarify usage of RooParametricStepFunction Jun 22, 2022
guitargeek added a commit that referenced this issue Jun 22, 2022
The `RooParametricStepFunction` is not used much, but still there is an
issue requesting to explain its usage better that needs to be closed.

I don't think it's worth it to have a tutorial for it, but nothing
speaks about having a little complete usage example script in the
reference guide instead of the code stub that is there right now.

This change to the documentation goes together with some gentle code
modernization in this commit.

Closes #7748.
@guitargeek guitargeek assigned guitargeek and unassigned lmoneta Jun 22, 2022
j-mathe pushed a commit to j-mathe/root that referenced this issue Jul 26, 2022
The `RooParametricStepFunction` is not used much, but still there is an
issue requesting to explain its usage better that needs to be closed.

I don't think it's worth it to have a tutorial for it, but nothing
speaks about having a little complete usage example script in the
reference guide instead of the code stub that is there right now.

This change to the documentation goes together with some gentle code
modernization in this commit.

Closes root-project#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants