Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROOT CMake fails if an external package sets a higher minimum CMake version #8280

Closed
davidrohr opened this issue May 31, 2021 · 0 comments · Fixed by #8341 or #8348
Closed

ROOT CMake fails if an external package sets a higher minimum CMake version #8280

davidrohr opened this issue May 31, 2021 · 0 comments · Fixed by #8341 or #8348
Assignees
@oshadura
Labels
bug in:Build System priority:critical
Milestone
6.24/02

Comments

@davidrohr
Copy link

davidrohr commented May 31, 2021 •
edited
Loading

The code

if (${CMAKE_MINIMUM_REQUIRED_VERSION} VERSION_GREATER_EQUAL "3.10.0")
    message(FATAL_ERROR "Remove this condition")

in the ROOT CMakeLists introduced in #6605 breaks the CMake configuration if another package sets a higher minimum version.
@davidrohr davidrohr added the bug label May 31, 2021
@Axel-Naumann Axel-Naumann modified the milestones: 6.24/02, 6.26/00 May 31, 2021
@oshadura oshadura mentioned this issue Jun 4, 2021
Merged
oshadura added a commit to oshadura/root that referenced this issue Jun 4, 2021
@oshadura
Remove not needed fatal message (fixing #root-project#8280)
d6efba1
oshadura added a commit to oshadura/root that referenced this issue Jun 4, 2021
@oshadura
Remove not needed fatal message (fixing #root-project#8280)
d8791e5
@oshadura oshadura mentioned this issue Jun 4, 2021
Merged
oshadura added a commit that referenced this issue Jun 7, 2021
@oshadura
Remove not needed fatal message (fixing ##8280)
da13622
oshadura added a commit to oshadura/root that referenced this issue Jun 7, 2021
@oshadura
Remove not needed fatal message (fixing #root-project#8280)
8375010
@oshadura oshadura linked a pull request Jun 7, 2021 that will close this issue
Remove not needed fatal message (fixing ##8280) #8348
Merged
oshadura added a commit that referenced this issue Jun 7, 2021
@oshadura
Remove not needed fatal message (fixing ##8280)
1bed887
pzhristov pushed a commit to alisw/root that referenced this issue Aug 27, 2021
@oshadura
Remove not needed fatal message (fixing #root-project#8280)
aaa266a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oshadura oshadura

Labels
bug in:Build System priority:critical
Projects
None yet
Milestone
6.24/02
3 participants
@Axel-Naumann @oshadura @davidrohr