Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for tmva-sofie test compilation #10117

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fixes for tmva-sofie test compilation #10117

merged 1 commit into from
Mar 16, 2022

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Mar 15, 2022 •
edited
Loading

This Pull request:

Changes or fixes:

  • Link to the blas library found by cmake, not hardcoded "blas".
  • Set ROOTIGNOREPREFIX=1 when running built binaries during build.
  • Make sure PCH is created before running emitters.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ellert ellert requested a review from bellenot as a code owner March 15, 2022 08:39
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@ellert
Link to the blas library found by cmake, not hardcoded "blas".
1aa9231 
Set ROOTIGNOREPREFIX=1 when running built binaries during build.
Make sure PCH is created before running emitters.
@ellert ellert force-pushed the blas-linking-and-ignore-prefix branch from 080bf8d to 1aa9231 Compare March 15, 2022 13:57
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@couet couet requested a review from lmoneta March 16, 2022 14:45
lmoneta
lmoneta approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for the fix

@lmoneta lmoneta merged commit 4e19f47 into root-project:master Mar 16, 2022
@ellert ellert deleted the blas-linking-and-ignore-prefix branch April 7, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta lmoneta approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@lmoneta lmoneta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellert @phsft-bot @lmoneta