[math] Don't #include "Math/Error.h" and "Math/Util.h" in Minuit2 headers
#13646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
lmoneta and
hageboeck
as code owners
|
Starting build on |
guitargeek
changed the title
#include "Math/Error.h" in mathcore headers used by Minuit2#include "Math/Error.h" and "Math/Utils.h" in mathcore headers used by Minuit2
guitargeek
changed the title
#include "Math/Error.h" and "Math/Utils.h" in mathcore headers used by Minuit2#include "Math/Error.h" and "Math/Utils.h" in Minuit2 headers
|
Build failed on mac11/noimt. Errors:
|
guitargeek
changed the title
#include "Math/Error.h" and "Math/Utils.h" in Minuit2 headers#include "Math/Error.h" and "Math/Util.h" in Minuit2 headers
guitargeek
force-pushed
the
minuit2_math_error
branch
from
21e37dd
to
466258e
Compare
The "Math/Error.h" header is not shipped with standalone Minuit2. It is not a perfect solution to just ship it with Minuit2, because the Error.h header behaves differently depending on the `MATHCORE_STANDALONE` macro being defined or not. The code would only work correctly if the user defines the `MATHCORE_STANDALONE` herself in the user code that uses standalone Minuit2, which would be annoying. Instead, this commit proposes another solution to the problem: for all headers also used in Minuit2 standalone, MathCore moves the definitions of all functions that use `Math/Error.h` out of the header files in the cxx files. Like this, the `Math/Error.h` is only a build dependency of standalone Minuit2, and the user doesn't need to define the `MATHCORE_STANDALONE` macro for it to work. Including the "Math/Util.h" header needs to be avoided for similar reasons (it's about another preprocessor macro related to `veccore`).
|
Starting build on |
|
Build failed on mac11/noimt. Errors:
|
lmoneta
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Math/Error.h" header is not shipped with standalone Minuit2.
It is not a perfect solution to just ship it with Minuit2, because the Error.h header behaves differently depending on the
MATHCORE_STANDALONEmacro being defined or not. The code would only work correctly if the user defines theMATHCORE_STANDALONEherself in the user code that uses standalone Minuit2, which would be annoying.Instead, this commit proposes another solution to the problem: for all headers also used in Minuit2 standalone, MathCore
moves the definitions of all functions that use
Math/Error.hout of the header files in the cxx files. Like this, theMath/Error.his only a build dependency of standalone Minuit2, and the user doesn't need to define theMATHCORE_STANDALONEmacro for it to work.Including the "Math/Util.h" header needs to be avoided for similar reasons (it's about another preprocessor macro related to
veccore).