Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[math] Don't #include "Math/Error.h" and "Math/Util.h" in Minuit2 headers #13646

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[math] Don't #include "Math/Error.h" and "Math/Util.h" in Minuit2 headers #13646

merged 1 commit into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. [math] Don't incl. "Math/Error.h" and "Math/Util.h" in Minuit2 headers 

    The "Math/Error.h" header is not shipped with standalone Minuit2.

It is not a perfect solution to just ship it with Minuit2, because the
Error.h header behaves differently depending on the
`MATHCORE_STANDALONE` macro being defined or not. The code would only
work correctly if the user defines the `MATHCORE_STANDALONE` herself in
the user code that uses standalone Minuit2, which would be annoying.

Instead, this commit proposes another solution to the problem: for all
headers also used in Minuit2 standalone, MathCore
moves the definitions of all functions that use `Math/Error.h` out of
the header files in the cxx files. Like this, the `Math/Error.h` is only
a build dependency of standalone Minuit2, and the user doesn't need to
define the `MATHCORE_STANDALONE` macro for it to work.

Including the "Math/Util.h" header needs to be avoided for similar
reasons (it's about another preprocessor macro related to `veccore`).
    @guitargeek
    guitargeek committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    466258e View commit details
    Browse the repository at this point in the history