Update TGraph2D properties before painting

[linev]

TGraph2DPainter keep pointers on TGraph2D data,
but was not checking if these values were changed.

Fixes problem reported https://root-forum.cern.ch/t/56816/

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[phsft-bot]

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\rfield_vector.cxx(26,1): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\rfield_vector.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(270,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\rfield_vector.cxx(26,17): error C2672: 'std::vector<CustomStruct,std::allocator<CustomStruct>>::emplace_back': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\rfield_vector.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\rfield_vector.cxx(27,1): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\rfield_vector.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(273,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\rfield_vector.cxx(27,17): error C2672: 'std::vector<CustomStruct,std::allocator<CustomStruct>>::emplace_back': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\rfield_vector.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(275,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\rfield_vector.cxx(32,1): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\rfield_vector.vcxproj]
• [2023-10-23T12:10:59.585Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\ntuple_show.cxx(277,22): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'CustomStruct' [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\ntuple_show.vcxproj]
• [2023-10-23T12:10:59.959Z] C:\build\workspace\root-pullrequests-build\root\tree\ntuple\v7\test\rfield_vector.cxx(32,17): error C2672: 'std::vector<CustomStruct,std::allocator<CustomStruct>>::emplace_back': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\tree\ntuple\v7\test\rfield_vector.vcxproj]

And 12 more

[github-actions]

Test Results

       10 files         10 suites   1d 22h 34m 10s ⏱️
  2 446 tests   2 443 ✔️ 0 💤 3 ❌
24 297 runs  24 289 ✔️ 0 💤 8 ❌

For more details on these failures, see this check.

Results for commit 1c27861.

[vepadulano]

Hi @linev , thanks for this improvement! Is there any test with the mentioned reproducer?

[linev]

Reproducer is in the forum post

[couet]

lgtm

[vepadulano]

It's not really what I meant :)

[linev]

Macro can run in batch, but one cannot really test result of the running macro.
Problem is missing drawing of TGraph2D points. We do not have reliable methods to check if these drawing done or not.

Very inaccurate method is size of produced png or gif image. Probably it will be larger with correct drawing, but not sure.

[vepadulano]

Alright, thanks for the explanation!