[skip-ci][tmva] Add tmva python requirements #14685
Conversation
|
Can one of the admins verify this patch? |
lobis
changed the title
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
hahnjo
changed the title
|
Running this through CI won't do much; the interesting time will be once this is merged and the CI images are rebuilt |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/soversion. Failing tests: |
|
Build failed on mac12arm/cxx20. Failing tests: |
|
This change would clarify the contract with our users: @vepadulano would you agree? |
|
Hello @lobis! Can you pls rebase the PR on top of ROOT |
lobis
requested review from
bellenot,
linev,
osschar,
jblomer,
martamaja10,
couet,
pcanal,
lmoneta,
guitargeek,
gganis,
vgvassilev and
agheata
as code owners
Done. Sorry about the spam, I did the rebasing quickly and modified a bunch of unintended files which triggered these many reviewers (I cannot remove them). |
The `onnx` Python module is required for TMVA SOFIE.
Adding this will fix the test failures of
`gtest-tmva-sofie-test-TestSofieModels`:
```
[ RUN ] SOFIE.Linear_B1
using batch-size = 1 input dim = 10 nlayers = 4
input data torch.Size([1, 10])
tensor([[1., 1., 1., 1., 1., 1., 1., 1., 1., 1.]])
Traceback (most recent call last):
File "/py-venv/ROOT-CI/lib/python3.8/site-packages/torch/onnx/_internal/onnx_proto_utils.py", line 221, in _add_onnxscript_fn
import onnx
ModuleNotFoundError: No module named 'onnx'
```
There was a problem hiding this comment.
Thanks for the PR!
Sorry that it needed rebasing again, we updated the requirements.txt file a bit too much recently.
I rebased and cleaned up your commit a little bit, so that you can move on:
- avoid duplicate entries
- sort entries alphabetically
- add
onnx, which is a requirement for TMVA SOFIE. Many platforms fail right now because this requirement is missing. - comment
graph_netsandsonnetout for now. We don't want to install any new optional dependencies on the CI platforms right now: the CI is very unstable because of TMVA, and we don't want to add new tests for now that would suddenly pop up because of the added optional dependency
This should probably be backported to the 6.32 branch, such that the release advocates the right dependencies.
This Pull request:
Changes or fixes:
Add TMVA python optional packages. CI should now run some additional tests that were skipped due to missing packages.
I tested the installation of the requirements.txt on python 3.10.
Checklist:
This PR fixes #14553