[v632] Backport some fixes for CI #15292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `onnx` Python module is required for TMVA SOFIE.
Adding this will fix the test failures of
`gtest-tmva-sofie-test-TestSofieModels`:
```
[ RUN ] SOFIE.Linear_B1
using batch-size = 1 input dim = 10 nlayers = 4
input data torch.Size([1, 10])
tensor([[1., 1., 1., 1., 1., 1., 1., 1., 1., 1.]])
Traceback (most recent call last):
File "/py-venv/ROOT-CI/lib/python3.8/site-packages/torch/onnx/_internal/onnx_proto_utils.py", line 221, in _add_onnxscript_fn
import onnx
ModuleNotFoundError: No module named 'onnx'
```
The test should be just removed since the initial reason for having that test is now void. The reason was to have *some way* to check that the packages we thought we had on our CI machines were actually there, since the Jenkins node didn't have any environment management. Now with the github actions CI our environment is more properly managed, at least for Linux. MacOS should get the same treatment at some point, but we can now more safely say "we know which packages are installed on the CI" than before.
Apply the same fix as in a561a9f, but for PyTorch.
guitargeek
requested review from
bellenot,
couet,
dpiparo and
vepadulano
as code owners
Test Results 5 files 5 suites 12h 14m 31s ⏱️ For more details on these failures, see this check. Results for commit 5ebbf91. |
guitargeek
merged commit 4514ad9
into
root-project:v6-32-00-patches
5 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport some PRs related to CI testing: